OCPBUGS-82973: align frr-k8s 25/3/2026#2945
Conversation
frr-k8s no longer uses kube-rbac-proxy, but instead exposes the TLS endpoints directly. The TLS parameters (fed by OCP TLS Profile) should be passed as flags to the frr-k8s binaries, to be done in a seperate commit. Signed-off-by: Ori Braunshtein <[email protected]> Assisted-by: Cursor
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
/testwith openshift/cluster-network-operator/master/frrk8s-e2e openshift/frr#128 |
Signed-off-by: Ori Braunshtein <[email protected]>
We have e2es that rely on the poll-interval being low, here we add a support to modify it through the configmap, to be set by CI lanes. Signed-off-by: Ori Braunshtein <[email protected]> Assisted-by: Cursor
oribon
force-pushed
the
frrk8s_tls_manifests
branch
from
9655f93 to
85820d3
Compare
|
/testwith openshift/cluster-network-operator/master/frrk8s-e2e openshift/frr#128 |
|
I didn't do a super thorough review. however subject to passing |
openshift-ci
Bot
added
lgtm
|
/testwith openshift/cluster-network-operator/master/frrk8s-e2e openshift/frr#128 |
We missed this binary when introducing the configmap Signed-off-by: Ori Braunshtein <[email protected]> Changes to be committed:
oribon
force-pushed
the
frrk8s_tls_manifests
branch
from
4ebf872 to
f9c3dc6
Compare
|
/testwith openshift/cluster-network-operator/master/frrk8s-e2e openshift/frr#128 |
|
/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp openshift/frr#128 |
|
/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/frr#128 |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/testwith openshift/cluster-network-operator/master/frrk8s-e2e openshift/frr#128 |
|
/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp |
|
/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp openshift/frr#128 |
|
@fedepaol, |
|
/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp openshift/frr#128 |
|
/jira refresh |
openshift-ci-robot
added
jira/invalid-bug
|
@tssurya: This pull request references Jira Issue OCPBUGS-82973, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.22 |
|
@tssurya: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick cancel |
|
@tssurya: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-cherrypick-robot no I mean don't cherry-pick since bug is only on 5.0 |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@tssurya: This pull request references Jira Issue OCPBUGS-82973, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@fedepaol for lgtm |
|
/lgtm |
|
/tide refresh |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreaskaris, fedepaol, jcaamano, oribon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@oribon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
obsolete by #2963 |
|
@oribon: This pull request references Jira Issue OCPBUGS-82973. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
7 participants
Aligning the frr-k8s manifests with openshift/frr#128, the 2 major changes are:
the 2 other commits are for e2e passing downstream, as upstream has these assumptions already baked in